Okay, let's structure this into a more organized project with modules for better maintainability. We'll create the following files: 1. `src/Shared/Constants.lua`: Stores shared constants like IDs, settings, etc. 2. `src/Client/Utils.lua`: Contains utility functions (sound playback, fading, tweening). 3. `src/Client/ButtonEffects.lua`: Handles the visual and audio feedback for buttons. 4. `src/Client/CinematicController.lua`: Manages the actual cinematic sequence. 5. `src/Client/ClassSelectionClient.lua`: The main client script that ties everything together. --[[ Shared constants used by both client and server (if applicable), or just across different client scripts. ]] local Constants = {} -- Asset IDs (Replace placeholders) Constants.SOUND_IDS = { TRANSFORM_START = "rbxassetid://YOUR_START_SOUND_ID", -- Sound played when transformation begins RISE = "rbxassetid://YOUR_RISE_SOUND_ID", -- Sound for character ascending PEAK = "rbxassetid://YOUR_PEAK_SOUND_ID", -- Sound at the peak of ascent DESCEND = "rbxassetid://YOUR_DESCEND_SOUND_ID", -- Sound for character descending COMPLETE = "rbxassetid://YOUR_COMPLETE_SOUND_ID", -- Sound when transformation completes -- Default Button Sounds BUTTON_HOVER_DEFAULT = "rbxassetid://9120548866", -- Default hover sound BUTTON_EXTRA_DEFAULT = "rbxassetid://8622763277", -- Default click/action sound -- Class-Specific Button Sounds (Examples) BUTTON_HOVER_VOID = "rbxassetid://9126213993", -- Hover sound for Void button BUTTON_HOVER_LIGHT = "rbxassetid://1841760659", -- Hover sound for Light button BUTTON_HOVER_CLOSE = "", -- Hover sound for Close button (optional) } Constants.STAR_SKYBOX = { SkyboxBk = "rbxassetid://163208827", SkyboxDn = "rbxassetid://163208726", SkyboxFt = "rbxassetid://163208689", SkyboxLf = "rbxassetid://163208661", SkyboxRt = "rbxassetid://163208590", SkyboxUp = "rbxassetid://163208536" } -- Visuals Constants.CLASS_COLORS = { Abyss = Color3.fromRGB(0, 100, 200), Light = Color3.fromRGB(255, 255, 180), Void = Color3.fromRGB(120, 0, 200) } -- Animation & Cinematic Settings Constants.ANIMATION_SETTINGS = { -- Character Movement FLOAT_HEIGHT = 100, -- How high the character floats ASCENT_DURATION = 3.5, -- Time taken to rise DESCEND_DURATION = 2.8, -- Time taken to fall back HOLD_DURATION = 2.0, -- Time spent at the peak -- Camera Control CAMERA_STANDARD_OFFSET_POS = Vector3.new(0, 5, -22), -- Default camera offset from character CAMERA_PEAK_OFFSET_POS = Vector3.new(0, 0, 28), -- Camera offset at peak height (relative to character) CAMERA_ORBIT_ANGLE = math.pi, -- Total angle camera orbits during ascent (180 degrees) CAMERA_FOLLOW_LERP_SPEED = 0.1, -- Smoothness of camera following (higher = faster) CAMERA_RETURN_DURATION = 0.8, -- Time for camera to return to normal position -- Visual Effects SKYBOX_FADE_DURATION = 0.5, -- Duration of fade in/out transitions SKYBOX_FADE_MAX_OPACITY = 0.85, -- How opaque the fade screen becomes (0 = invisible, 1 = black) -- Physics (AlignPosition) ALIGN_POSITION_MAX_FORCE = 100000, -- Max force to keep character stable at peak ALIGN_POSITION_RESPONSIVENESS = 200, -- How quickly AlignPosition reacts } -- Button Animation Settings Constants.BUTTON_ANIM_SETTINGS = { ButtonHover = { Time = 0.15, Scale = 1.08, EasingStyle = Enum.EasingStyle.Quint, EasingDirection = Enum.EasingDirection.Out }, ButtonPress = { Time = 0.1, Scale = 0.95, EasingStyle = Enum.EasingStyle.Quint, EasingDirection = Enum.EasingDirection.Out }, ButtonRelease = { Time = 0.12, Scale = 1, EasingStyle = Enum.EasingStyle.Quint, EasingDirection = Enum.EasingDirection.Out }, -- Scale 1 means return to normal ButtonReleaseHover = { Time = 0.12, Scale = 1.08, EasingStyle = Enum.EasingStyle.Quint, EasingDirection = Enum.EasingDirection.Out } -- Scale matches hover scale } Constants.BUTTON_SIZES = { Default = { Size = 200, ParentSize = 220 }, -- Image size and parent frame size Close = { Size = 48, ParentSize = 51 } } -- Remote Event Names Constants.REMOTE_EVENTS = { SELECT_CLASS = "SelectClassEvent", LOAD_CLASS = "LoadClassEvent" } -- GUI Names Constants.GUI_NAMES = { ABYSS = "AbyssGUI", LIGHT = "LightGUI", VOID = "VoidGUI", CLASS_SELECTION = "ClassSelectionGUI", FADE_TRANSITION_PREFIX = "TransitionFadeGui" } -- NPC Info Constants.NPC_INFO = { CLASS_SELECTOR_NPC_NAME = "Sukuna", PROXIMITY_PROMPT_NAME = "ProximityPrompt" -- Assuming default name } return Constants --[[ Utility functions for client-side operations like sound playback, UI effects, and tweening. ]] local TweenService = game:GetService("TweenService") local SoundService = game:GetService("SoundService") local Players = game:GetService("Players") local ReplicatedStorage = game:GetService("ReplicatedStorage") local Constants = require(ReplicatedStorage.WaitForChild("src").Shared.Constants) -- Adjust path if needed local Utils = {} local player = Players.LocalPlayer local playerGui = player:WaitForChild("PlayerGui") -- Plays a sound once and cleans it up afterwards. -- @param soundId (string) The rbxassetid:// of the sound. -- @param volume (number, optional) Volume from 0 to 1 (default 0.5). -- @param parent (Instance, optional) Instance to parent the sound to (default SoundService). -- @param pitch (number, optional) Playback speed/pitch (default 1). -- @return (Sound) The created sound instance, or nil if soundId is invalid. function Utils.playSound(soundId, volume, parent, pitch) if not soundId or soundId == "" or soundId:match("YOUR_") then warn("Attempted to play invalid soundId:", soundId) return nil end local sound = Instance.new("Sound") sound.SoundId = soundId sound.Volume = volume or 0.5 sound.Pitch = pitch or 1 sound.Parent = parent or SoundService -- Handle potential loading issues sound.Loaded:Wait(5) -- Wait up to 5 seconds for the sound to load if not sound.IsLoaded then warn("Sound failed to load:", soundId) sound:Destroy() return nil end sound:Play() -- Use task.delay for cleanup, ensuring sound exists before destroying task.delay(sound.TimeLength / sound.Pitch + 0.1, function() if sound and sound.Parent then sound:Destroy() end end) return sound end -- Creates a reusable sound instance, typically for UI feedback. -- @param soundId (string) The rbxassetid:// of the sound. -- @param volume (number) Volume from 0 to 1. -- @param parent (Instance) Instance to parent the sound to. -- @return (Sound) The created sound instance, or nil if soundId is invalid. function Utils.createPersistentSound(soundId, volume, parent) if not soundId or soundId == "" or soundId:match("YOUR_") then -- Silently ignore invalid IDs for UI sounds as they might be intentionally blank -- warn("Attempted to create persistent sound with invalid soundId:", soundId) return nil end local sound = Instance.new("Sound") sound.SoundId = soundId sound.Volume = volume sound.Looped = false sound.Parent = parent return sound end -- Creates a screen fade effect (in or out). -- @param duration (number) How long the fade takes. -- @param fadeIn (boolean) True to fade in (screen becomes visible), false to fade out (screen becomes black). -- @param destroyPreviousGui (Instance, optional) A GUI instance to destroy when this fade completes. -- @return (Tween) The fade tween instance. -- @return (ScreenGui) The GUI instance created for the fade effect. function Utils.createFadeEffect(duration, fadeIn, destroyPreviousGui) local fadeGui = Instance.new("ScreenGui", playerGui) fadeGui.Name = Constants.GUI_NAMES.FADE_TRANSITION_PREFIX .. "_" .. (fadeIn and "In" or "Out") .. "_" .. math.random(1000) fadeGui.ResetOnSpawn = false fadeGui.ZIndexBehavior = Enum.ZIndexBehavior.Sibling fadeGui.DisplayOrder = 999 -- Ensure it's on top fadeGui.IgnoreGuiInset = true local fadeFrame = Instance.new("Frame", fadeGui) fadeFrame.Name = "FadeFrame" fadeFrame.BackgroundColor3 = Color3.new(0, 0, 0) fadeFrame.BorderSizePixel = 0 fadeFrame.Size = UDim2.new(1, 0, 1, 0) local maxOpacity = Constants.ANIMATION_SETTINGS.SKYBOX_FADE_MAX_OPACITY local startTransparency = fadeIn and (1 - maxOpacity) or 0 -- Fade in starts mostly opaque, fade out starts visible local endTransparency = fadeIn and 1 or (1 - maxOpacity) -- Fade in ends invisible, fade out ends mostly opaque fadeFrame.BackgroundTransparency = startTransparency local tweenInfo = TweenInfo.new(duration, Enum.EasingStyle.Sine, Enum.EasingDirection.Out) local fadeTween = TweenService:Create(fadeFrame, tweenInfo, { BackgroundTransparency = endTransparency }) local connection connection = fadeTween.Completed:Connect(function(playbackState) connection:Disconnect() -- Only destroy the fade GUI if it was a fade-IN (becomes invisible) if fadeIn then if fadeGui and fadeGui.Parent then fadeGui:Destroy() end end -- Destroy the *previous* GUI if one was provided (useful for chaining fades) if destroyPreviousGui and destroyPreviousGui.Parent then destroyPreviousGui:Destroy() end end) fadeTween:Play() return fadeTween, fadeGui end -- Simple wrapper for creating tweens. -- @param object (Instance) The instance to tween. -- @param properties (table) A dictionary of properties to tween. -- @param info (table) A table containing tween settings: Time, EasingStyle, EasingDirection. -- @return (Tween) The created tween instance. function Utils.createTween(object, properties, info) local tweenInfo = TweenInfo.new( info.Time or 0.5, info.EasingStyle or Enum.EasingStyle.Quint, info.EasingDirection or Enum.EasingDirection.Out, info.RepeatCount or 0, info.Reverses or false, info.DelayTime or 0 ) return TweenService:Create(object, tweenInfo, properties) end -- Captures current skybox properties. -- @param sky (Sky) The Sky instance. -- @return (table) A dictionary of original skybox properties. function Utils.captureSkyProperties(sky) local originalProperties = {} if not sky then return originalProperties end print("Capturing original sky properties...") for _, propName in ipairs({"SkyboxBk", "SkyboxDn", "SkyboxFt", "SkyboxLf", "SkyboxRt", "SkyboxUp", "CelestialBodiesShown", "MoonAngularSize", "MoonTextureId", "StarCount", "SunAngularSize", "SunTextureId"}) do if pcall(function() return sky[propName] end) then -- Check if property exists originalProperties[propName] = sky[propName] print(string.format(" - Captured: %s = %s", propName, tostring(originalProperties[propName]))) end end if next(originalProperties) == nil then print("Warning: No original sky properties were captured!") end return originalProperties end -- Restores skybox properties from a saved table. -- @param sky (Sky) The Sky instance. -- @param properties (table) The table of properties to restore. function Utils.restoreSkyProperties(sky, properties) if not sky or not properties or next(properties) == nil then print("Warning: Cannot restore sky properties - invalid input or empty properties table.") return end print("Restoring original sky properties...") for propName, value in pairs(properties) do if pcall(function() sky[propName] = value end) then -- Check if property exists before setting print(string.format(" - Restoring: %s = %s", propName, tostring(value))) else warn(string.format(" - Failed to restore property: %s (may not exist on this Sky instance)", propName)) end end print("Sky restoration attempt complete.") end -- Applies a specific skybox configuration. -- @param sky (Sky) The Sky instance. -- @param skyboxConfig (table) The table containing the skybox asset IDs (e.g., Constants.STAR_SKYBOX). function Utils.applySkybox(sky, skyboxConfig) if not sky or not skyboxConfig then return end print("Applying new skybox properties...") for property, value in pairs(skyboxConfig) do if pcall(function() sky[property] = value end) then print(string.format(" - Setting: %s = %s", property, tostring(value))) else warn(string.format(" - Failed to set property: %s (may not exist on this Sky instance)", property)) end end -- Optionally hide default celestial bodies for custom skyboxes if skyboxConfig.SkyboxUp then -- Heuristic: if it's a full skybox, hide default sun/moon sky.CelestialBodiesShown = false end print("New skybox applied.") end return Utils --[[ Handles setting up standard hover, press, and release effects (scaling and sound) for GUI buttons. ]] local UserInputService = game:GetService("UserInputService") local GuiService = game:GetService("GuiService") local ReplicatedStorage = game:GetService("ReplicatedStorage") local Constants = require(ReplicatedStorage.WaitForChild("src").Shared.Constants) local Utils = require(script.Parent.Utils) -- Assumes ButtonEffects is in the same folder as Utils local ButtonEffects = {} -- Sets up hover, press, and release effects for a button. -- Assumes the button has a child named "ImageOBJ" (ImageLabel or ImageButton) for scaling. -- @param button (GuiButton) The button instance. -- @param buttonType (string) Key from Constants.BUTTON_SIZES (e.g., "Default", "Close"). -- @param hoverSoundId (string) Asset ID for hover sound. -- @param hoverSoundVolume (number) Volume for hover sound. -- @param extraSoundId (string) Asset ID for click/press sound. -- @param extraSoundVolume (number) Volume for click/press sound. function ButtonEffects.setup(button, buttonType, hoverSoundId, hoverSoundVolume, extraSoundId, extraSoundVolume) if not button or not button:IsA("GuiButton") then warn("ButtonEffects.setup: Invalid button provided.") return end local imageObj = button:FindFirstChild("ImageOBJ") -- The visual element to scale if not imageObj or not (imageObj:IsA("ImageLabel") or imageObj:IsA("ImageButton")) then warn("ButtonEffects.setup: Button", button:GetFullName(), "is missing 'ImageOBJ' child or it's not an ImageLabel/ImageButton.") -- Fallback: Try scaling the button itself if ImageOBJ is missing imageObj = button -- return -- Or decide to proceed by scaling the button itself end local buttonData = Constants.BUTTON_SIZES[buttonType] or Constants.BUTTON_SIZES.Default local imageSize = buttonData.Size -- The base size of the image/button -- Use original size/position from the object itself if possible, otherwise calculate based on constants local originalSize = imageObj.Size local originalPosition = imageObj.Position -- Fallback if original size seems unset (UDim2.new()) if originalSize == UDim2.new() then originalSize = UDim2.new(0, imageSize, 0, imageSize) originalPosition = UDim2.new(0.5, -imageSize / 2, 0.5, -imageSize / 2) warn("ButtonEffects.setup: Using default size/pos for", imageObj:GetFullName()) end -- Create persistent sounds for reuse local hoverSound = Utils.createPersistentSound(hoverSoundId, hoverSoundVolume, button) local extraSound = Utils.createPersistentSound(extraSoundId, extraSoundVolume, button) local currentTween = nil -- Keep track of the active tween to cancel if needed local function playTween(properties, animSettings) if currentTween then currentTween:Cancel() end currentTween = Utils.createTween(imageObj, properties, animSettings) currentTween:Play() currentTween.Completed:Connect(function() if currentTween and currentTween.PlaybackState == Enum.TweenPlaybackState.Completed then currentTween = nil -- Clear reference only if this specific tween completed naturally end end) end -- Mouse Enter: Play hover sound, scale up button.MouseEnter:Connect(function() if hoverSound then hoverSound:Play() end local settings = Constants.BUTTON_ANIM_SETTINGS.ButtonHover local targetScale = settings.Scale playTween({ Size = UDim2.new(originalSize.Width.Scale, originalSize.Width.Offset * targetScale, originalSize.Height.Scale, originalSize.Height.Offset * targetScale), Position = UDim2.new(originalPosition.X.Scale, originalPosition.X.Offset - (originalSize.Width.Offset * (targetScale - 1) / 2), originalPosition.Y.Scale, originalPosition.Y.Offset - (originalSize.Height.Offset * (targetScale - 1) / 2)) }, settings) end) -- Mouse Leave: Stop hover sound, scale back to original button.MouseLeave:Connect(function() if hoverSound then hoverSound:Stop() end local settings = Constants.BUTTON_ANIM_SETTINGS.ButtonRelease playTween({ Size = originalSize, Position = originalPosition }, settings) end) -- Mouse Button 1 Down: Play extra sound, scale down button.MouseButton1Down:Connect(function() if extraSound then extraSound:Play() end local settings = Constants.BUTTON_ANIM_SETTINGS.ButtonPress local targetScale = settings.Scale playTween({ Size = UDim2.new(originalSize.Width.Scale, originalSize.Width.Offset * targetScale, originalSize.Height.Scale, originalSize.Height.Offset * targetScale), Position = UDim2.new(originalPosition.X.Scale, originalPosition.X.Offset - (originalSize.Width.Offset * (targetScale - 1) / 2), originalPosition.Y.Scale, originalPosition.Y.Offset - (originalSize.Height.Offset * (targetScale - 1) / 2)) }, settings) end) -- Mouse Button 1 Up: Scale back up (either to hover state or original state) button.MouseButton1Up:Connect(function() -- Check if mouse is still over the button on release local mouseLocation = UserInputService:GetMouseLocation() local guiInset = GuiService:GetGuiInset().Y local absolutePosition = button.AbsolutePosition local absoluteSize = button.AbsoluteSize local isMouseOver = mouseLocation.X >= absolutePosition.X and mouseLocation.X <= absolutePosition.X + absoluteSize.X and mouseLocation.Y >= absolutePosition.Y + guiInset and mouseLocation.Y <= absolutePosition.Y + absoluteSize.Y + guiInset if isMouseOver then -- Return to hover state scale local settings = Constants.BUTTON_ANIM_SETTINGS.ButtonReleaseHover local targetScale = settings.Scale playTween({ Size = UDim2.new(originalSize.Width.Scale, originalSize.Width.Offset * targetScale, originalSize.Height.Scale, originalSize.Height.Offset * targetScale), Position = UDim2.new(originalPosition.X.Scale, originalPosition.X.Offset - (originalSize.Width.Offset * (targetScale - 1) / 2), originalPosition.Y.Scale, originalPosition.Y.Offset - (originalSize.Height.Offset * (targetScale - 1) / 2)) }, settings) else -- Return to original state scale local settings = Constants.BUTTON_ANIM_SETTINGS.ButtonRelease playTween({ Size = originalSize, Position = originalPosition }, settings) end end) end return ButtonEffects --[[ Controls the post-class selection cinematic sequence. Handles character animation, camera movement, skybox changes, and effects. ]] local TweenService = game:GetService("TweenService") local Lighting = game:GetService("Lighting") local Players = game:GetService("Players") local RunService = game:GetService("RunService") local Workspace = game:GetService("Workspace") local ReplicatedStorage = game:GetService("ReplicatedStorage") local Constants = require(ReplicatedStorage.WaitForChild("src").Shared.Constants) local Utils = require(script.Parent.Utils) -- Assumes CinematicController is in the same folder as Utils local CinematicController = {} local player = Players.LocalPlayer local Camera = Workspace.CurrentCamera local sky = Lighting:FindFirstChildOfClass("Sky") or Instance.new("Sky", Lighting) local originalSkyProperties = {} local isCinematicPlaying = false local activeConnections = {} local activeTweens = {} local activeInstances = {} -- Store instances created during cinematic for cleanup local currentAnimationPhase = "Idle" -- Captures sky properties on module load task.defer(function() originalSkyProperties = Utils.captureSkyProperties(sky) end) -- Cleans up all resources used by the cinematic. local function cleanupCinematic(character, humanoid, originalState) print("Cinematic Cleanup Initiated...") isCinematicPlaying = false currentAnimationPhase = "Cleanup" -- Disconnect all active connections for name, conn in pairs(activeConnections) do if conn then conn:Disconnect() print(" - Disconnected:", name) end activeConnections[name] = nil end -- Cancel all active tweens for i, tween in ipairs(activeTweens) do if tween and tween.PlaybackState ~= Enum.TweenPlaybackState.Completed then tween:Cancel() print(" - Cancelled Tween:", i) end end activeTweens = {} -- Destroy created instances (AlignPosition, Attachments, Fade GUIs etc.) for _, instance in ipairs(activeInstances) do if instance and instance.Parent then print(" - Destroying Instance:", instance.Name) instance:Destroy() end end activeInstances = {} -- Restore player state if character and humanoid still exist if character and character.Parent and humanoid and humanoid.Parent then print(" - Restoring Player State...") local rootPart = character:FindFirstChild("HumanoidRootPart") if rootPart and rootPart.Anchored then rootPart.Anchored = false print(" - Unanchored RootPart") end humanoid.WalkSpeed = originalState.WalkSpeed humanoid.JumpPower = originalState.JumpPower humanoid:SetStateEnabled(Enum.HumanoidStateType.Jumping, true) print(string.format(" - Restored WalkSpeed (%s), JumpPower (%s), Jumping Enabled", originalState.WalkSpeed, originalState.JumpPower)) -- Ensure character is properly grounded if needed (optional) -- humanoid:ChangeState(Enum.HumanoidStateType.Running) else print(" - Character or Humanoid not found, skipping player state restoration.") end -- Restore camera state if Camera then Camera.CameraType = originalState.CameraType Camera.CameraSubject = originalState.CameraSubject print(string.format(" - Restored Camera Type (%s) and Subject (%s)", tostring(originalState.CameraType), tostring(originalState.CameraSubject))) end -- Restore Sky (attempt even if fade-in didn't fully complete) Utils.restoreSkyProperties(sky, originalSkyProperties) print("Cinematic Cleanup Complete.") end -- The main function to play the cinematic sequence. -- @param className (string) The name of the class selected (e.g., "Abyss"). function CinematicController.play(className) if isCinematicPlaying then warn("CinematicController.play: Already playing a cinematic.") return end local character = player.Character if not character then warn("CinematicController.play: Player character not found.") return end local rootPart = character:FindFirstChild("HumanoidRootPart") local humanoid = character:FindFirstChild("Humanoid") if not rootPart or not humanoid then warn("CinematicController.play: HumanoidRootPart or Humanoid not found.") return end isCinematicPlaying = true currentAnimationPhase = "Start" print("Starting Class Transformation Cinematic for:", className) -- Store original state local originalState = { WalkSpeed = humanoid.WalkSpeed, JumpPower = humanoid.JumpPower, CFrame = rootPart.CFrame, CameraCFrame = Camera.CFrame, CameraType = Camera.CameraType, CameraSubject = Camera.CameraSubject, } -- Prepare character and camera humanoid.WalkSpeed = 0 humanoid.JumpPower = 0 humanoid:SetStateEnabled(Enum.HumanoidStateType.Jumping, false) if rootPart.Anchored then rootPart.Anchored = false end -- Ensure not anchored initially Camera.CameraType = Enum.CameraType.Scriptable local cleanupFunc = function() cleanupCinematic(character, humanoid, originalState) end -- Use task.spawn to run the sequence, allowing the main thread to continue -- Wrap in xpcall for robust error handling and cleanup task.spawn(function() local success, err = xpcall(function() -- === Phase 1: Initial Fade Out and Skybox Change === currentAnimationPhase = "FadeOut1" print("Phase: FadeOut1") local fadeOutTween, fadeOutGui = Utils.createFadeEffect(Constants.ANIMATION_SETTINGS.SKYBOX_FADE_DURATION, false) table.insert(activeTweens, fadeOutTween) table.insert(activeInstances, fadeOutGui) -- Track GUI for cleanup Utils.playSound(Constants.SOUND_IDS.TRANSFORM_START, 0.7, rootPart) -- Wait for fade out to complete before changing sky if fadeOutTween then fadeOutTween.Completed:Wait() end Utils.applySkybox(sky, Constants.STAR_SKYBOX) -- === Phase 2: Fade In with New Skybox === currentAnimationPhase = "FadeIn1" print("Phase: FadeIn1") local fadeInTween, fadeInGui = Utils.createFadeEffect(Constants.ANIMATION_SETTINGS.SKYBOX_FADE_DURATION, true, fadeOutGui) -- Destroy fadeOutGui on completion table.insert(activeTweens, fadeInTween) -- fadeInGui is destroyed automatically by createFadeEffect, but track just in case table.insert(activeInstances, fadeInGui) if fadeInTween then fadeInTween.Completed:Wait() end -- === Phase 3: Character Ascent and Camera Orbit === currentAnimationPhase = "Ascent" print("Phase: Ascent") local ascentStartY = rootPart.Position.Y local ascentTargetCFrame = originalState.CFrame + Vector3.new(0, Constants.ANIMATION_SETTINGS.FLOAT_HEIGHT, 0) local ascentEndY = ascentTargetCFrame.Position.Y local ascentTween = Utils.createTween(rootPart, { CFrame = ascentTargetCFrame }, { Time = Constants.ANIMATION_SETTINGS.ASCENT_DURATION, EasingStyle = Enum.EasingStyle.Sine, EasingDirection = Enum.EasingDirection.InOut }) table.insert(activeTweens, ascentTween) ascentTween:Play() Utils.playSound(Constants.SOUND_IDS.RISE, 0.7, rootPart) -- Start camera following local ascentCamProgress = 0 activeConnections.CameraFollow = RunService.RenderStepped:Connect(function(dt) if not rootPart or not rootPart.Parent or not Camera or not isCinematicPlaying then if activeConnections.CameraFollow then activeConnections.CameraFollow:Disconnect(); activeConnections.CameraFollow = nil end return end local targetLookAt = rootPart.Position local targetCamCFrame if currentAnimationPhase == "Ascent" then if ascentEndY ~= ascentStartY then ascentCamProgress = math.clamp((rootPart.Position.Y - ascentStartY) / (ascentEndY - ascentStartY), 0, 1) end local verticalOffset = Constants.ANIMATION_SETTINGS.CAMERA_STANDARD_OFFSET_POS:Lerp(Constants.ANIMATION_SETTINGS.CAMERA_PEAK_OFFSET_POS, ascentCamProgress) local currentAngle = Constants.ANIMATION_SETTINGS.CAMERA_ORBIT_ANGLE * ascentCamProgress local rotatedOffset = CFrame.Angles(0, currentAngle, 0) * CFrame.new(Constants.ANIMATION_SETTINGS.CAMERA_STANDARD_OFFSET_POS) -- Apply the interpolated vertical offset separately rotatedOffset = rotatedOffset + Vector3.new(0, verticalOffset.Y - Constants.ANIMATION_SETTINGS.CAMERA_STANDARD_OFFSET_POS.Y, 0) local targetCamPos = targetLookAt + rotatedOffset.Position targetCamCFrame = CFrame.lookAt(targetCamPos, targetLookAt) elseif currentAnimationPhase == "Hold" then -- Camera holds position relative to the peak, looking from behind local rotatedOffset = CFrame.Angles(0, Constants.ANIMATION_SETTINGS.CAMERA_ORBIT_ANGLE, 0) * CFrame.new(Constants.ANIMATION_SETTINGS.CAMERA_PEAK_OFFSET_POS) local targetCamPos = targetLookAt + rotatedOffset.Position targetCamCFrame = CFrame.lookAt(targetCamPos, targetLookAt) elseif currentAnimationPhase == "Descent" then -- Interpolate from the peak camera position back to the standard front position local descendStartY = ascentEndY -- Peak height is where descent starts local descendEndY = originalState.CFrame.Position.Y -- Ground level is where descent ends local descentProgress = 0 if descendStartY ~= descendEndY then descentProgress = math.clamp((descendStartY - rootPart.Position.Y) / (descendStartY - descendEndY), 0, 1) end -- Define start (peak) and end (standard) camera CFrames relative to the character local peakRotatedOffset = CFrame.Angles(0, Constants.ANIMATION_SETTINGS.CAMERA_ORBIT_ANGLE, 0) * CFrame.new(Constants.ANIMATION_SETTINGS.CAMERA_PEAK_OFFSET_POS) local peakCamPos = targetLookAt + peakRotatedOffset.Position local peakCamCFrame = CFrame.lookAt(peakCamPos, targetLookAt) local standardCamPos = targetLookAt + Constants.ANIMATION_SETTINGS.CAMERA_STANDARD_OFFSET_POS local standardCamCFrame = CFrame.lookAt(standardCamPos, targetLookAt) targetCamCFrame = peakCamCFrame:Lerp(standardCamCFrame, descentProgress) elseif currentAnimationPhase == "Landed" then -- Snap or lerp quickly to the standard position after landing local targetCamPos = targetLookAt + Constants.ANIMATION_SETTINGS.CAMERA_STANDARD_OFFSET_POS targetCamCFrame = CFrame.lookAt(targetCamPos, targetLookAt) else -- Default/fallback camera position (shouldn't be needed if phases are correct) local targetCamPos = targetLookAt + Constants.ANIMATION_SETTINGS.CAMERA_STANDARD_OFFSET_POS targetCamCFrame = CFrame.lookAt(targetCamPos, targetLookAt) end -- Apply lerp smoothly if targetCamCFrame then Camera.CFrame = Camera.CFrame:Lerp(targetCamCFrame, math.min(Constants.ANIMATION_SETTINGS.CAMERA_FOLLOW_LERP_SPEED * dt * 60, 1)) end end) if ascentTween then ascentTween.Completed:Wait() end -- === Phase 4: Hold at Peak === currentAnimationPhase = "Hold" print("Phase: Hold") Utils.playSound(Constants.SOUND_IDS.PEAK, 1.0, rootPart) -- Use AlignPosition to hold the character steady local rootPartAttachment = Instance.new("Attachment", rootPart) rootPartAttachment.Name = "AlignPositionAttachment" table.insert(activeInstances, rootPartAttachment) local alignPos = Instance.new("AlignPosition", rootPart) alignPos.Attachment0 = rootPartAttachment alignPos.Responsiveness = Constants.ANIMATION_SETTINGS.ALIGN_POSITION_RESPONSIVENESS alignPos.MaxForce = Constants.ANIMATION_SETTINGS.ALIGN_POSITION_MAX_FORCE alignPos.Position = rootPart.Position -- Lock to current peak position alignPos.Mode = Enum.PositionAlignmentMode.OneAttachment alignPos.Enabled = true table.insert(activeInstances, alignPos) task.wait(Constants.ANIMATION_SETTINGS.HOLD_DURATION) -- Disable AlignPosition before starting descent if alignPos and alignPos.Parent then alignPos.Enabled = false end -- === Phase 5: Character Descent === currentAnimationPhase = "Descent" print("Phase: Descent") local descendTargetCFrame = originalState.CFrame -- Target original ground position local descendTween = Utils.createTween(rootPart, { CFrame = descendTargetCFrame }, { Time = Constants.ANIMATION_SETTINGS.DESCEND_DURATION, EasingStyle = Enum.EasingStyle.Sine, EasingDirection = Enum.EasingDirection.In -- Ease in for landing }) table.insert(activeTweens, descendTween) descendTween:Play() Utils.playSound(Constants.SOUND_IDS.DESCEND, 0.8, rootPart) if descendTween then descendTween.Completed:Wait() end currentAnimationPhase = "Landed" print("Phase: Landed") -- Short pause on the ground task.wait(0.2) -- Stop camera follow *after* landing and brief pause if activeConnections.CameraFollow then activeConnections.CameraFollow:Disconnect(); activeConnections.CameraFollow = nil end -- === Phase 6: Final Fade Out === currentAnimationPhase = "FadeOut2" print("Phase: FadeOut2") local finalFadeOutTween, finalFadeOutGui = Utils.createFadeEffect(Constants.ANIMATION_SETTINGS.SKYBOX_FADE_DURATION, false) table.insert(activeTweens, finalFadeOutTween) table.insert(activeInstances, finalFadeOutGui) Utils.playSound(Constants.SOUND_IDS.COMPLETE, 0.5, rootPart) if finalFadeOutTween then finalFadeOutTween.Completed:Wait() end -- === Phase 7: Restore Original State (Sky, Player, Camera) & Fade In === currentAnimationPhase = "Restoration" print("Phase: Restoration") -- Restore player controls and physics humanoid.WalkSpeed = originalState.WalkSpeed humanoid.JumpPower = originalState.JumpPower humanoid:SetStateEnabled(Enum.HumanoidStateType.Jumping, true) -- Restore skybox (happens behind the fade) Utils.restoreSkyProperties(sky, originalSkyProperties) -- Start camera return tween (happens during fade in) local cameraReturnTween = Utils.createTween(Camera, { CFrame = originalState.CameraCFrame }, { Time = Constants.ANIMATION_SETTINGS.CAMERA_RETURN_DURATION, EasingStyle = Enum.EasingStyle.Sine, EasingDirection = Enum.EasingDirection.InOut }) table.insert(activeTweens, cameraReturnTween) cameraReturnTween:Play() -- Restore camera type/subject *after* tween completes cameraReturnTween.Completed:Connect(function() if Camera then -- Check if camera still exists Camera.CameraType = originalState.CameraType Camera.CameraSubject = originalState.CameraSubject end end) -- Final Fade In currentAnimationPhase = "FadeIn2" print("Phase: FadeIn2") local finalFadeInTween, finalFadeInGui = Utils.createFadeEffect(Constants.ANIMATION_SETTINGS.SKYBOX_FADE_DURATION, true, finalFadeOutGui) -- Destroy finalFadeOutGui table.insert(activeTweens, finalFadeInTween) table.insert(activeInstances, finalFadeInGui) -- Track just in case if finalFadeInTween then finalFadeInTween.Completed:Wait() end currentAnimationPhase = "Finished" print("Cinematic Sequence Completed Successfully.") end, function(err) -- Error handler for xpcall warn("Error during cinematic sequence:", err) debug.traceback(err) -- Attempt cleanup even if an error occurred cleanupFunc() end) -- If xpcall finished without errors, run cleanup if success then cleanupFunc() end end) end return CinematicController --[[ Main client script for class selection. Handles UI interactions, triggers the cinematic, and communicates with the server. ]] local Players = game:GetService("Players") local ReplicatedStorage = game:GetService("ReplicatedStorage") local Workspace = game:GetService("Workspace") -- Wait for modules to be available in ReplicatedStorage local srcFolder = ReplicatedStorage:WaitForChild("src") local Constants = require(srcFolder.Shared.Constants) local ButtonEffects = require(srcFolder.Client.ButtonEffects) local CinematicController = require(srcFolder.Client.CinematicController) -- Utils might not be directly needed here if ButtonEffects and CinematicController use it internally local player = Players.LocalPlayer local playerGui = player:WaitForChild("PlayerGui") -- GUI References local guiMap = { [Constants.GUI_NAMES.ABYSS] = playerGui:WaitForChild(Constants.GUI_NAMES.ABYSS), [Constants.GUI_NAMES.LIGHT] = playerGui:WaitForChild(Constants.GUI_NAMES.LIGHT), [Constants.GUI_NAMES.VOID] = playerGui:WaitForChild(Constants.GUI_NAMES.VOID), } local ClassSelectionGUI = playerGui:WaitForChild(Constants.GUI_NAMES.CLASS_SELECTION) -- Remote Event References local selectClassEvent = ReplicatedStorage:WaitForChild(Constants.REMOTE_EVENTS.SELECT_CLASS) local loadClassEvent = ReplicatedStorage:WaitForChild(Constants.REMOTE_EVENTS.LOAD_CLASS) local currentClass = nil -- Stores the player's currently loaded class name -- Function to handle selecting a class local function selectClass(className) print("Attempting to select class:", className) selectClassEvent:FireServer(className) ClassSelectionGUI.Enabled = false -- The cinematic controller handles the visual transformation CinematicController.play(className) end -- Setup Connections for Class Selection Buttons local function setupSelectionGUI() local selectionFrame = ClassSelectionGUI:WaitForChild("Frame") -- Assuming buttons are in a 'Frame' local AbyssButton = selectionFrame:WaitForChild("AbyssButton") local VoidButton = selectionFrame:WaitForChild("VoidButton") local LightButton = selectionFrame:WaitForChild("LightButton") local CloseButton = selectionFrame:WaitForChild("CloseButton") -- Connect button clicks to the selectClass function AbyssButton.MouseButton1Click:Connect(function() selectClass("Abyss") end) VoidButton.MouseButton1Click:Connect(function() selectClass("Void") end) LightButton.MouseButton1Click:Connect(function() selectClass("Light") end) -- Close button just hides the GUI CloseButton.MouseButton1Click:Connect(function() ClassSelectionGUI.Enabled = false end) -- Apply button effects (using constants) ButtonEffects.setup(AbyssButton, "Default", Constants.SOUND_IDS.BUTTON_HOVER_DEFAULT, 0.3, Constants.SOUND_IDS.BUTTON_EXTRA_DEFAULT, 0.6) ButtonEffects.setup(VoidButton, "Default", Constants.SOUND_IDS.BUTTON_HOVER_VOID, 0.2, Constants.SOUND_IDS.BUTTON_EXTRA_DEFAULT, 0.6) ButtonEffects.setup(LightButton, "Default", Constants.SOUND_IDS.BUTTON_HOVER_LIGHT, 0.3, Constants.SOUND_IDS.BUTTON_EXTRA_DEFAULT, 0.6) ButtonEffects.setup(CloseButton, "Close", Constants.SOUND_IDS.BUTTON_HOVER_CLOSE, 0, -- No hover sound for close nil, 0) -- No extra sound for close print("Class Selection GUI buttons configured.") end -- Listen for the server telling us what class the player has loadClassEvent.OnClientEvent:Connect(function(className) print("Received class data from server:", className) if className and Constants.CLASS_COLORS[className] then -- Check if it's a valid class name we know currentClass = className else currentClass = nil -- No class or invalid class name end end) -- Setup Proximity Prompt Trigger for NPC local function setupNPCTrigger() local npc = Workspace.NPCs:WaitForChild(Constants.NPC_INFO.CLASS_SELECTOR_NPC_NAME, 15) -- Wait up to 15 seconds for NPC if not npc then warn("NPC", Constants.NPC_INFO.CLASS_SELECTOR_NPC_NAME, "not found in Workspace.NPCs") return end local proximityPrompt = npc:WaitForChild(Constants.NPC_INFO.PROXIMITY_PROMPT_NAME, 5) if not proximityPrompt or not proximityPrompt:IsA("ProximityPrompt") then warn("ProximityPrompt", Constants.NPC_INFO.PROXIMITY_PROMPT_NAME, "not found or not a ProximityPrompt in", npc:GetFullName()) return end proximityPrompt.Triggered:Connect(function(playerWhoTriggered) if playerWhoTriggered ~= player then return end -- Ensure it's the local player triggering print("NPC ProximityPrompt triggered.") if currentClass then -- Player already has a class, show their specific GUI (if it exists) local classGuiName = Constants.GUI_NAMES[string.upper(currentClass)] -- e.g., Constants.GUI_NAMES.ABYSS if classGuiName and guiMap[classGuiName] then print("Player has class:", currentClass, "- Showing specific GUI:", classGuiName) -- Disable all other class GUIs and the selection GUI first for _, gui in pairs(guiMap) do gui.Enabled = false end ClassSelectionGUI.Enabled = false -- Enable the correct one guiMap[classGuiName].Enabled = true else -- Fallback to selection GUI if specific GUI doesn't exist or class name is wrong warn("No specific GUI found for class:", currentClass, "- Showing Class Selection GUI.") ClassSelectionGUI.Enabled = true end else -- Player has no class, show the selection GUI print("Player has no class - Showing Class Selection GUI.") ClassSelectionGUI.Enabled = true end end) print("NPC ProximityPrompt trigger configured for:", npc:GetFullName()) end -- Initialization local function initialize() print("Initializing ClassSelectionClient...") ClassSelectionGUI.Enabled = false -- Ensure it starts hidden for _, gui in pairs(guiMap) do gui.Enabled = false end -- Ensure class-specific GUIs start hidden setupSelectionGUI() setupNPCTrigger() -- Request class data from the server upon joining/starting script print("Requesting initial class data from server...") loadClassEvent:FireServer() print("ClassSelectionClient Initialized.") end initialize() **Explanation of Changes and Structure:** 1. **`src/Shared/Constants.lua`**: * Centralizes all magic numbers, asset IDs, names, and settings. This makes tweaking values much easier. * Includes sections for Sounds, Skybox, Colors, Animation, Buttons, Remotes, GUIs, and NPCs. * Using a shared module allows potential server scripts to access the same constants if needed (like RemoteEvent names). 2. **`src/Client/Utils.lua`**: * Contains helper functions: `playSound`, `createPersistentSound`, `createFadeEffect`, `createTween`, `captureSkyProperties`, `restoreSkyProperties`, `applySkybox`. * These are general-purpose functions used by other client modules. * Requires `Constants` for settings like fade opacity. * Improved sound playback with loading checks and warnings. * More robust skybox handling, capturing/restoring more properties and checking existence. 3. **`src/Client/ButtonEffects.lua`**: * Dedicated module for applying standardized button effects. * The `setup` function takes a button and configuration details. * Uses `Utils.createPersistentSound` and `Utils.createTween`. * Requires `Constants` for animation timings, scales, and button sizes. * Improved logic for scaling based on original size and centering. * Handles tween cancellation better. 4. **`src/Client/CinematicController.lua`**: * Focuses *only* on the cinematic sequence. * Requires `Constants` and `Utils`. * Uses a state variable `isCinematicPlaying` to prevent overlaps. * Uses `currentAnimationPhase` for logic control (especially camera). * Implements a robust `cleanupCinematic` function to restore *all* original states (player controls, camera, skybox) and clean up tweens, connections, and created instances. * Uses `xpcall` to wrap the main sequence, ensuring cleanup runs even if errors occur. * Manages active tweens, connections, and temporary instances in tables for easier cleanup. * Camera logic refined for ascent, hold, and descent phases. * Uses `AlignPosition` for holding the character at the peak. * Handles skybox changes and restoration via `Utils`. 5. **`src/Client/ClassSelectionClient.lua`**: * The main orchestrator script. * Requires `Constants`, `ButtonEffects`, and `CinematicController`. * Handles references to GUIs and RemoteEvents using constants. * Connects UI button clicks (`setupSelectionGUI`) and NPC interaction (`setupNPCTrigger`). * Calls `ButtonEffects.setup` for each button. * Calls `CinematicController.play` when a class is selected. * Listens for `loadClassEvent` to know the player's current class. * Handles the logic for showing either the class selection GUI or a class-specific GUI based on `currentClass`. * Requests initial class data on startup. This modular structure makes the code significantly easier to read, debug, and extend. Each part has a clear responsibility. Remember to place these files in the correct paths within your Roblox project (e.g., under `ReplicatedStorage/src/Client`, `ReplicatedStorage/src/Shared`). You will also need to create the `SelectClassEvent` and `LoadClassEvent` RemoteEvents in `ReplicatedStorage`.