Okay, let's overhaul the script with a more modular and modern approach. We'll break it down into logical components to improve readability, maintainability, and hopefully resolve the lingering visibility and artifact issues. We will create the following structure: /home/user/ ├── client/ │ ├── ClassTransformation/ │ │ ├── Config.lua │ │ ├── Effects.lua │ │ ├── UI.lua │ │ ├── Utils.lua │ │ └── Transformation.lua │ └── ClassTransformationClient.lua (Main entry point) ``` This structure separates configuration, effect logic, UI handling, utility functions, and the main transformation sequence. -- client/ClassTransformation/Config.lua -- Configuration settings for the Class Transformation effect local Config = {} --[[ Services ]] Config.Services = { TweenService = game:GetService("TweenService"), ReplicatedStorage = game:GetService("ReplicatedStorage"), Lighting = game:GetService("Lighting"), SoundService = game:GetService("SoundService"), Players = game:GetService("Players"), UserInputService = game:GetService("UserInputService"), RunService = game:GetService("RunService"), GuiService = game:GetService("GuiService"), } --[[ Player & Camera References (Set at runtime) ]] Config.Player = Config.Services.Players.LocalPlayer Config.Camera = workspace.CurrentCamera --[[ GUI References ]] Config.PlayerGui = Config.Player:WaitForChild("PlayerGui") Config.GuiMap = { Abyss = Config.PlayerGui:WaitForChild("AbyssGUI"), Light = Config.PlayerGui:WaitForChild("LightGUI"), Void = Config.PlayerGui:WaitForChild("VoidGUI"), } Config.ClassSelectionGUI = Config.PlayerGui:WaitForChild("ClassSelectionGUI") --[[ Remote Events ]] Config.Remotes = { SelectClass = Config.Services.ReplicatedStorage:WaitForChild("SelectClassEvent"), LoadClass = Config.Services.ReplicatedStorage:WaitForChild("LoadClassEvent"), } --[[ Skybox ]] Config.STAR_SKYBOX = { SkyboxBk = "rbxassetid://159454299", SkyboxDn = "rbxassetid://159454296", SkyboxFt = "rbxassetid://159454300", SkyboxLf = "rbxassetid://159454298", SkyboxRt = "rbxassetid://159454297", SkyboxUp = "rbxassetid://159454295" } --[[ Class Properties ]] Config.CLASS_COLORS = { Abyss = Color3.fromRGB(0, 100, 200), Light = Color3.fromRGB(255, 255, 180), Void = Color3.fromRGB(120, 0, 200), Default = Color3.new(1, 1, 1) } --[[ Sound IDs ]] Config.SOUND_IDS = { TRANSFORM_START = "rbxassetid://YOUR_START_SOUND_ID", RISE = "rbxassetid://YOUR_RISE_SOUND_ID", WAVE = "rbxassetid://YOUR_WAVE_SOUND_ID", COMPLETE = "rbxassetid://YOUR_COMPLETE_SOUND_ID", BUTTON_HOVER_DEFAULT = "rbxassetid://9120548866", BUTTON_EXTRA_DEFAULT = "rbxassetid://8622763277", BUTTON_HOVER_VOID = "rbxassetid://9126213993", BUTTON_HOVER_LIGHT = "rbxassetid://1841760659", BUTTON_HOVER_CLOSE = "", -- No sound for close } --[[ Effect Timings & Properties ]] Config.EFFECT_SETTINGS = { -- General Timing FADE_DURATION = 0.8, FLOAT_DURATION = 2.5, GLOW_FADE_IN_DURATION = 1.0, GLOW_FADE_OUT_DURATION = 1.0, CAMERA_RETURN_DURATION = 1.0, -- Aura AURA_RATE = 150, AURA_SIZE = NumberSequence.new{NumberSequenceKeypoint.new(0, 1.5), NumberSequenceKeypoint.new(0.5, 3), NumberSequenceKeypoint.new(1, 2)}, AURA_SPEED = NumberRange.new(3, 6), AURA_LIFETIME = NumberRange.new(0.5, 1.2), AURA_LIGHT_EMISSION = 0.5, -- Trail TRAIL_LIFETIME = 0.6, TRAIL_WIDTH_SCALE = NumberSequence.new(6, 0), TRAIL_LIGHT_EMISSION = 0.5, TRAIL_TRANSPARENCY = NumberSequence.new(0.3, 1), TRAIL_ATTACHMENT_OFFSET = Vector3.new(0, -1.5, 0), -- Waves WAVE_COUNT = 3, WAVE_INITIAL_SIZE = Vector3.new(0.1, 15, 0.1), WAVE_FINAL_SIZE = Vector3.new(60, 15, 60), WAVE_DURATION = 1.3, WAVE_DELAY = 0.25, WAVE_TRANSPARENCY_START = 0.2, WAVE_TRANSPARENCY_END = 1, WAVE_MATERIAL = Enum.Material.Neon, -- Float FLOAT_HEIGHT = 40, -- Camera CAMERA_STANDARD_OFFSET = CFrame.new(0, 8, -20), CAMERA_FOLLOW_LERP_SPEED = 0.1, -- Fade FADE_MAX_OPACITY = 0.9, -- Slightly less than 1 to potentially avoid full black issues -- Glow GLOW_RANGE = 30, GLOW_BRIGHTNESS = 1.5, } --[[ UI Animation Settings ]] Config.UI = { BUTTON_SIZES = { Default = {Size = 200, ParentSize = 220}, Close = {Size = 48, ParentSize = 51} }, ANIMATION_SETTINGS = { ButtonHover = {Time = 0.15, Scale = 1.08, EasingStyle = Enum.EasingStyle.Quint, EasingDirection = Enum.EasingDirection.Out}, ButtonPress = {Time = 0.1, Scale = 0.95, EasingStyle = Enum.EasingStyle.Quint, EasingDirection = Enum.EasingDirection.Out}, ButtonRelease = {Time = 0.12, Scale = 1, EasingStyle = Enum.EasingStyle.Quint, EasingDirection = Enum.EasingDirection.Out} } } --[[ Original Skybox Cache ]] Config.OriginalSky = { Properties = {} } task.defer(function() -- Defer to ensure Lighting is fully loaded local sky = Config.Services.Lighting:FindFirstChildOfClass("Sky") or Instance.new("Sky", Config.Services.Lighting) Config.OriginalSky.Instance = sky for _, propName in ipairs({"SkyboxBk", "SkyboxDn", "SkyboxFt", "SkyboxLf", "SkyboxRt", "SkyboxUp", "CelestialBodiesShown", "Atmosphere", "SunAngularSize"}) do pcall(function() Config.OriginalSky.Properties[propName] = sky[propName] end) end print("Original sky properties cached.") end) return Config -- client/ClassTransformation/Utils.lua -- Utility functions for Class Transformation local Config = require(script.Parent.Config) local TweenService = Config.Services.TweenService local SoundService = Config.Services.SoundService local PlayerGui = Config.PlayerGui local Utils = {} --[[ Sound Playback ]] function Utils.playSound(soundId, volume, parent, autoDestroy) autoDestroy = if autoDestroy == nil then true else autoDestroy -- Default to true if not soundId or soundId == "" then return nil end local sound = Instance.new("Sound") sound.SoundId = soundId sound.Volume = volume or 0.5 sound.Parent = parent or SoundService -- Parent before playing for replication sound:Play() if autoDestroy then -- Use task.delay for safer cleanup after sound finishes task.delay(sound.TimeLength + 0.1, function() if sound and sound.Parent then sound:Destroy() end end) end return sound end --[[ Tween Creation ]] function Utils.createTween(object, properties, duration, easingStyle, easingDirection, delayTime, repeatCount, reverses) local info = TweenInfo.new( duration or 0.5, easingStyle or Enum.EasingStyle.Linear, easingDirection or Enum.EasingDirection.Out, repeatCount or 0, reverses or false, delayTime or 0 ) return TweenService:Create(object, info, properties) end --[[ Screen Fade Logic ]] local fadeGui = nil local fadeFrame = nil local function getFadeFrame() if fadeGui and fadeGui.Parent == PlayerGui and fadeFrame and fadeFrame.Parent == fadeGui then return fadeFrame end if fadeGui and fadeGui.Parent then fadeGui:Destroy() end -- Cleanup old if needed fadeGui = Instance.new("ScreenGui", PlayerGui) fadeGui.Name = "PersistentFadeGui" fadeGui.ResetOnSpawn = false fadeGui.ZIndexBehavior = Enum.ZIndexBehavior.Sibling fadeGui.DisplayOrder = 1000 -- Ensure it's on top fadeGui.IgnoreGuiInset = true fadeGui.Enabled = false -- Start disabled fadeFrame = Instance.new("Frame", fadeGui) fadeFrame.Name = "FadeFrame" fadeFrame.BackgroundColor3 = Color3.new(0, 0, 0) fadeFrame.BorderSizePixel = 0 fadeFrame.Size = UDim2.new(1, 0, 1, 0) fadeFrame.BackgroundTransparency = 1 -- Start fully transparent return fadeFrame end -- Runs a fade and returns the tween instance function Utils.runFade(fadeType, duration) local frame = getFadeFrame() local startTransparency, endTransparency if fadeType == "Out" then -- Clear -> Black startTransparency = 1 endTransparency = 1 - Config.EFFECT_SETTINGS.FADE_MAX_OPACITY elseif fadeType == "In" then -- Black -> Clear startTransparency = 1 - Config.EFFECT_SETTINGS.FADE_MAX_OPACITY endTransparency = 1 else warn("Utils.runFade: Invalid fadeType:", fadeType) return nil end --print(string.format("Run Fade: %s (Duration: %.2f, StartT: %.2f, EndT: %.2f)", fadeType, duration, startTransparency, endTransparency)) frame.BackgroundTransparency = startTransparency frame.Parent.Enabled = true -- Make sure GUI is enabled local fadeTween = Utils.createTween(frame, {BackgroundTransparency = endTransparency}, duration, Enum.EasingStyle.Sine, Enum.EasingDirection.Out) local connection connection = fadeTween.Completed:Connect(function(playbackState) connection:Disconnect() --print(string.format("Fade Tween Completed: %s (State: %s)", fadeType, tostring(playbackState))) if fadeType == "In" and playbackState == Enum.TweenStatus.Completed then -- Disable GUI only if fully faded in and completed successfully if frame and frame.Parent then frame.Parent.Enabled = false end end end) fadeTween:Play() return fadeTween end -- Waits for a tween to complete function Utils.waitForTween(tween) if not tween then return end if tween.PlaybackState == Enum.PlaybackState.Playing then tween.Completed:Wait() end end --[[ Character Transparency Reset ]] function Utils.resetCharacterTransparency(character) if not character then return end print("Utils: Resetting character transparency...") local humanoid = character:FindFirstChildOfClass("Humanoid") -- Reset Humanoid properties that might affect visibility (though less common) if humanoid then pcall(function() humanoid.Transparency = 0 end) -- Older property, might still exist? end for _, descendant in ipairs(character:GetDescendants()) do if descendant:IsA("BasePart") or descendant:IsA("Decal") then local success1, err1 = pcall(function() descendant.LocalTransparencyModifier = 0 end) local success2, err2 = pcall(function() descendant.Transparency = 0 end) -- if not success1 then warn("Failed to set LocalTransparencyModifier:", err1, descendant:GetFullName()) end -- if not success2 then warn("Failed to set Transparency:", err2, descendant:GetFullName()) end end end print("Utils: Character transparency reset attempt complete.") end return Utils -- client/ClassTransformation/Effects.lua -- Handles creation and management of visual/audio effects local Config = require(script.Parent.Config) local Utils = require(script.Parent.Utils) local TweenService = Config.Services.TweenService local Effects = {} --[[ Aura Effect ]] function Effects.createAura(parent, color) local settings = Config.EFFECT_SETTINGS local aura = Instance.new("ParticleEmitter", parent) aura.Name = "TransformationAura" aura.Color = ColorSequence.new(color) aura.LightEmission = settings.AURA_LIGHT_EMISSION aura.Size = settings.AURA_SIZE aura.Rate = settings.AURA_RATE aura.Speed = settings.AURA_SPEED aura.Lifetime = settings.AURA_LIFETIME aura.Enabled = false -- Start disabled return aura end --[[ Glow Effect ]] function Effects.createGlow(parent, color) local settings = Config.EFFECT_SETTINGS local glow = Instance.new("PointLight", parent) glow.Name = "TransformationGlow" glow.Color = color glow.Range = 0 glow.Brightness = 0 glow.Shadows = false return glow end function Effects.tweenGlow(glow, fadeIn) local settings = Config.EFFECT_SETTINGS local targetRange = fadeIn and settings.GLOW_RANGE or 0 local targetBrightness = fadeIn and settings.GLOW_BRIGHTNESS or 0 local duration = fadeIn and settings.GLOW_FADE_IN_DURATION or settings.GLOW_FADE_OUT_DURATION local easing = fadeIn and Enum.EasingStyle.Quad or Enum.EasingStyle.Sine -- Fade in Quad, Fade out Sine local direction = fadeIn and Enum.EasingDirection.Out or Enum.EasingDirection.In local tween = Utils.createTween(glow, {Range = targetRange, Brightness = targetBrightness}, duration, easing, direction) tween:Play() return tween end --[[ Trail Effect ]] function Effects.createTrail(rootPart, color) local settings = Config.EFFECT_SETTINGS local attachment0 = Instance.new("Attachment", rootPart); attachment0.Name = "TrailAttach0" local attachment1 = Instance.new("Attachment", rootPart); attachment1.Name = "TrailAttach1"; attachment1.Position = settings.TRAIL_ATTACHMENT_OFFSET local trail = Instance.new("Trail", rootPart) -- Parent to RootPart so it follows trail.Name = "TransformationTrail" trail.Attachment0 = attachment0 trail.Attachment1 = attachment1 trail.Color = ColorSequence.new(color) trail.LightEmission = settings.TRAIL_LIGHT_EMISSION trail.Lifetime = settings.TRAIL_LIFETIME trail.Transparency = settings.TRAIL_TRANSPARENCY trail.WidthScale = settings.TRAIL_WIDTH_SCALE trail.Enabled = false -- Start disabled -- Return all parts for cleanup return trail, attachment0, attachment1 end --[[ Energy Wave Effect ]] function Effects.spawnEnergyWaves(container, originCFrame, color, humanoidHipHeight) local settings = Config.EFFECT_SETTINGS local soundId = Config.SOUND_IDS.WAVE local activeTweens = {} -- Store wave tweens locally for this spawn task.spawn(function() for i = 1, settings.WAVE_COUNT do -- Check if container still exists before creating wave if not container or not container.Parent then print("Effects: Wave container destroyed, stopping wave spawn.") break end local waveStartPos = originCFrame.Position + Vector3.new(0, -humanoidHipHeight + 1, 0) -- Spawn near feet local energyWave = Instance.new("Part", container) -- Parent to container energyWave.Name = "EnergyWave_" .. i energyWave.Size = settings.WAVE_INITIAL_SIZE energyWave.Material = settings.WAVE_MATERIAL energyWave.Color = color energyWave.Anchored = true energyWave.CanCollide = false energyWave.CFrame = CFrame.new(waveStartPos) energyWave.Transparency = settings.WAVE_TRANSPARENCY_START local waveExpandTween = Utils.createTween( energyWave, {Size = settings.WAVE_FINAL_SIZE, Transparency = settings.WAVE_TRANSPARENCY_END}, settings.WAVE_DURATION, Enum.EasingStyle.Quad, Enum.EasingDirection.Out ) activeTweens["wave"..i] = waveExpandTween -- Store tween -- Cleanup wave when tween completes local connection connection = waveExpandTween.Completed:Connect(function() connection:Disconnect() if energyWave and energyWave.Parent then energyWave:Destroy() end activeTweens["wave"..i] = nil -- Remove from active list end) waveExpandTween:Play() Utils.playSound(soundId, 0.4, energyWave, true) -- Play sound attached to wave part -- Check container again before waiting if container and container.Parent then task.wait(settings.WAVE_DELAY) else print("Effects: Wave container destroyed during delay, stopping wave spawn.") break -- Exit loop if container is gone end end print("Effects: Energy waves finished spawning.") end) -- Note: We don't return the tweens here as they manage their own lifecycle via Completed event end --[[ Skybox Management ]] function Effects.setSkybox(isStarry) local sky = Config.OriginalSky.Instance if not sky then warn("Effects: Sky instance not found!"); return end local targetProperties = isStarry and Config.STAR_SKYBOX or Config.OriginalSky.Properties print("Effects: Setting skybox -", (isStarry and "Starry" or "Original")) for propName, value in pairs(targetProperties) do local success, err = pcall(function() sky[propName] = value end) -- if not success then warn("Effects: Failed to set sky property", propName, err) end end end return Effects -- client/ClassTransformation/UI.lua -- Handles UI interactions and animations for Class Selection local Config = require(script.Parent.Config) local Utils = require(script.Parent.Utils) local UI = {} local ClassSelectionGUI = Config.ClassSelectionGUI local GuiMap = Config.GuiMap local BUTTON_SIZES = Config.UI.BUTTON_SIZES local ANIMATION_SETTINGS = Config.UI.ANIMATION_SETTINGS local SOUND_IDS = Config.SOUND_IDS --[[ Button Effect Setup ]] function UI.setupButtonEffects(button, buttonType, hoverSoundId, hoverSoundVolume, extraSoundId, extraSoundVolume) if not button:IsA("GuiButton") then return end local imageObj = button:FindFirstChild("ImageOBJ") -- Assuming structure has ImageOBJ inside local buttonData = BUTTON_SIZES[buttonType] or BUTTON_SIZES.Default local imageSize = buttonData.Size -- Create sounds only if ID is provided local hoverSound = (hoverSoundId and hoverSoundId ~= "") and Utils.playSound(hoverSoundId, hoverSoundVolume, button, false) -- Don't auto-destroy hover sounds local extraSound = (extraSoundId and extraSoundId ~= "") and Utils.playSound(extraSoundId, extraSoundVolume, button, false) local currentHoverTween = nil local currentPressTween = nil button.MouseEnter:Connect(function() if hoverSound then hoverSound:Play() end if extraSound then extraSound:Play() end if imageObj then if currentPressTween then currentPressTween:Cancel() end -- Cancel press anim if hovering again if currentHoverTween then currentHoverTween:Cancel() end local hoverSettings = ANIMATION_SETTINGS.ButtonHover local targetSize = UDim2.new(0, imageSize * hoverSettings.Scale, 0, imageSize * hoverSettings.Scale) local targetPos = UDim2.new(0.5, -imageSize * hoverSettings.Scale / 2, 0.5, -imageSize * hoverSettings.Scale / 2) currentHoverTween = Utils.createTween(imageObj, {Size = targetSize, Position = targetPos}, hoverSettings.Time, hoverSettings.EasingStyle, hoverSettings.EasingDirection) currentHoverTween:Play() end end) button.MouseLeave:Connect(function() if hoverSound then hoverSound:Stop() end if extraSound then extraSound:Stop() end if imageObj then if currentPressTween then currentPressTween:Cancel() end if currentHoverTween then currentHoverTween:Cancel() end local releaseSettings = ANIMATION_SETTINGS.ButtonRelease local targetSize = UDim2.new(0, imageSize, 0, imageSize) local targetPos = UDim2.new(0.5, -imageSize / 2, 0.5, -imageSize / 2) currentHoverTween = Utils.createTween(imageObj, {Size = targetSize, Position = targetPos}, releaseSettings.Time, releaseSettings.EasingStyle, releaseSettings.EasingDirection) currentHoverTween:Play() end end) button.MouseButton1Down:Connect(function() if imageObj then if currentHoverTween then currentHoverTween:Cancel() end if currentPressTween then currentPressTween:Cancel() end local pressSettings = ANIMATION_SETTINGS.ButtonPress local targetSize = UDim2.new(0, imageSize * pressSettings.Scale, 0, imageSize * pressSettings.Scale) local targetPos = UDim2.new(0.5, -imageSize * pressSettings.Scale / 2, 0.5, -imageSize * pressSettings.Scale / 2) currentPressTween = Utils.createTween(imageObj, {Size = targetSize, Position = targetPos}, pressSettings.Time, pressSettings.EasingStyle, pressSettings.EasingDirection) currentPressTween:Play() end end) -- Optional: MouseButton1Up to return to hover state immediately button.MouseButton1Up:Connect(function() if imageObj then if currentPressTween then currentPressTween:Cancel(); currentPressTween = nil end -- Trigger MouseEnter logic again if mouse is still over button local mousePos = Config.Services.UserInputService:GetMouseLocation() local guiPos = button.AbsolutePosition local guiSize = button.AbsoluteSize if mousePos.X >= guiPos.X and mousePos.X <= guiPos.X + guiSize.X and mousePos.Y >= guiPos.Y and mousePos.Y <= guiPos.Y + guiSize.Y then button.MouseEnter:Fire() -- Re-fire hover effect else button.MouseLeave:Fire() -- Fire leave effect if mouse moved off end end end) -- Clean up sounds when button is destroyed button.Destroying:Connect(function() if hoverSound then hoverSound:Destroy() end if extraSound then extraSound:Destroy() end if currentHoverTween then currentHoverTween:Cancel() end if currentPressTween then currentPressTween:Cancel() end end) end --[[ Setup All Class Selection Buttons ]] function UI.initializeClassSelection() local frame = ClassSelectionGUI:WaitForChild("Frame") local abyssButton = frame:WaitForChild("AbyssButton") local voidButton = frame:WaitForChild("VoidButton") local lightButton = frame:WaitForChild("LightButton") local closeButton = frame:WaitForChild("CloseButton") UI.setupButtonEffects(abyssButton, "Default", SOUND_IDS.BUTTON_HOVER_DEFAULT, 0.3, SOUND_IDS.BUTTON_EXTRA_DEFAULT, 0.6) UI.setupButtonEffects(voidButton, "Default", SOUND_IDS.BUTTON_HOVER_VOID, 0.2) UI.setupButtonEffects(lightButton, "Default", SOUND_IDS.BUTTON_HOVER_LIGHT, 0.3) UI.setupButtonEffects(closeButton, "Close", SOUND_IDS.BUTTON_HOVER_CLOSE, 0) -- No sound for close -- Return buttons for connection in main script return abyssButton, voidButton, lightButton, closeButton end --[[ Show/Hide GUIs ]] function UI.showClassGUI(className) print("UI: Showing GUI for class:", className) for name, gui in pairs(GuiMap) do gui.Enabled = (name == className) end ClassSelectionGUI.Enabled = false -- Hide selection GUI end function UI.showSelectionGUI() print("UI: Showing Class Selection GUI") for _, gui in pairs(GuiMap) do gui.Enabled = false end ClassSelectionGUI.Enabled = true end function UI.hideAllClassGUIs() print("UI: Hiding all class-specific GUIs") for _, gui in pairs(GuiMap) do gui.Enabled = false end ClassSelectionGUI.Enabled = false end return UI -- client/ClassTransformation/Transformation.lua -- Main orchestration logic for the class transformation sequence local Config = require(script.Parent.Config) local Utils = require(script.Parent.Utils) local Effects = require(script.Parent.Effects) local UI = require(script.Parent.UI) local TweenService = Config.Services.TweenService local RunService = Config.Services.RunService local Camera = Config.Camera local Player = Config.Player local Transformation = {} local isTransforming = false -- Debounce flag -- Main transformation function function Transformation.play(className) if isTransforming then warn("Transformation: Already transforming, request ignored.") return end isTransforming = true print("Transformation: Starting for class -", className) local character = Player.Character if not character then warn("Transformation: Character not found."); isTransforming = false; return end local rootPart = character:FindFirstChild("HumanoidRootPart") local humanoid = character:FindFirstChild("Humanoid") if not rootPart or not humanoid then warn("Transformation: HumanoidRootPart or Humanoid not found."); isTransforming = false; return end -- Store original state local originalState = { WalkSpeed = humanoid.WalkSpeed, JumpPower = humanoid.JumpPower, CFrame = rootPart.CFrame, CameraCFrame = Camera.CFrame, CameraType = Camera.CameraType, CameraSubject = Camera.CameraSubject, IsJumpingEnabled = humanoid:GetStateEnabled(Enum.HumanoidStateType.Jumping) } -- Prepare for transformation humanoid.WalkSpeed = 0 humanoid.JumpPower = 0 humanoid:SetStateEnabled(Enum.HumanoidStateType.Jumping, false) if rootPart.Anchored then rootPart.Anchored = false end -- Ensure not anchored Camera.CameraType = Enum.CameraType.Scriptable local classColor = Config.CLASS_COLORS[className] or Config.CLASS_COLORS.Default local effectsContainer = Instance.new("Folder", workspace) -- Container for temporary effects effectsContainer.Name = "ClassTransformEffects_" .. Player.Name -- References to created effects for cleanup local activeTweens = {} local createdEffects = { aura = nil, glow = nil, trail = nil, trailAttach0 = nil, trailAttach1 = nil, cameraFollow = nil, container = effectsContainer } -- Cleanup function local function cleanup() print("Transformation: Running cleanup...") -- Disconnect connections if createdEffects.cameraFollow then createdEffects.cameraFollow:Disconnect(); createdEffects.cameraFollow = nil; print(" -> Camera follow disconnected.") end -- Cancel active tweens for name, tween in pairs(activeTweens) do if tween then print(" -> Cancelling tween:", name); pcall(function() tween:Cancel() end) end end; activeTweens = {} -- Destroy created instances safely for key, effect in pairs(createdEffects) do if effect and effect:IsA("Instance") and effect.Parent then print(" -> Destroying effect:", key) effect:Destroy() end createdEffects[key] = nil -- Clear reference end -- Ensure container is destroyed if not already handled if effectsContainer and effectsContainer.Parent then effectsContainer:Destroy(); print(" -> Effects container destroyed.") end -- Restore player state (final check) pcall(function() if humanoid and humanoid.Parent then humanoid.WalkSpeed = originalState.WalkSpeed humanoid.JumpPower = originalState.JumpPower humanoid:SetStateEnabled(Enum.HumanoidStateType.Jumping, originalState.IsJumpingEnabled) end if Camera then Camera.CameraType = originalState.CameraType Camera.CameraSubject = originalState.CameraSubject end -- Ensure character is visible after cleanup Utils.resetCharacterTransparency(character) end) print("Transformation: Cleanup complete.") isTransforming = false -- Release debounce flag end -- Sequence using task.spawn for pseudo-async flow task.spawn(function() local success, err = pcall(function() -- 1. Fade Out, Change Sky print("Step 1: Fade Out & Set Skybox") activeTweens.fade1 = Utils.runFade("Out", Config.EFFECT_SETTINGS.FADE_DURATION) Utils.playSound(Config.SOUND_IDS.TRANSFORM_START, 0.7, rootPart) Effects.setSkybox(true) -- Set starry sky Utils.waitForTween(activeTweens.fade1) -- 2. Fade In, Create Effects print("Step 2: Fade In & Create Effects") activeTweens.fade2 = Utils.runFade("In", Config.EFFECT_SETTINGS.FADE_DURATION) createdEffects.aura = Effects.createAura(rootPart, classColor) createdEffects.glow = Effects.createGlow(rootPart, classColor) createdEffects.trail, createdEffects.trailAttach0, createdEffects.trailAttach1 = Effects.createTrail(rootPart, classColor) activeTweens.glowIn = Effects.tweenGlow(createdEffects.glow, true) -- Start glow fade in Utils.waitForTween(activeTweens.fade2) -- 3. Float Up, Enable Effects, Start Camera Follow print("Step 3: Float Up & Enable Effects") local targetFloatCFrame = originalState.CFrame + Vector3.new(0, Config.EFFECT_SETTINGS.FLOAT_HEIGHT, 0) activeTweens.float = Utils.createTween(rootPart, {CFrame = targetFloatCFrame}, Config.EFFECT_SETTINGS.FLOAT_DURATION, Enum.EasingStyle.Sine, Enum.EasingDirection.Out) activeTweens.float:Play() Utils.playSound(Config.SOUND_IDS.RISE, 0.8, rootPart) if createdEffects.aura then createdEffects.aura.Enabled = true end if createdEffects.trail then createdEffects.trail.Enabled = true end -- Start Camera Follow createdEffects.cameraFollow = RunService.RenderStepped:Connect(function() if rootPart and rootPart.Parent and Camera then local targetCamCFrame = rootPart.CFrame * Config.EFFECT_SETTINGS.CAMERA_STANDARD_OFFSET Camera.CFrame = Camera.CFrame:Lerp(targetCamCFrame, Config.EFFECT_SETTINGS.CAMERA_FOLLOW_LERP_SPEED) elseif createdEffects.cameraFollow then createdEffects.cameraFollow:Disconnect(); createdEffects.cameraFollow = nil -- Auto-disconnect if rootPart gone end end) -- 4. Spawn Energy Waves (Runs concurrently) print("Step 4: Spawn Energy Waves") Effects.spawnEnergyWaves(effectsContainer, originalState.CFrame, classColor, humanoid.HipHeight) -- Wait for float to complete Utils.waitForTween(activeTweens.float) if createdEffects.trail then createdEffects.trail.Enabled = false end -- Disable trail after float -- 5. Post-Float Actions (Stop Follow, Disable Aura, Fade Glow) print("Step 5: Post-Float Actions") if createdEffects.cameraFollow then createdEffects.cameraFollow:Disconnect(); createdEffects.cameraFollow = nil end if createdEffects.aura then createdEffects.aura.Enabled = false end if createdEffects.glow then activeTweens.glowOut = Effects.tweenGlow(createdEffects.glow, false) end -- Start glow fade out -- Wait briefly for glow fade out to progress (optional, adjust as needed) task.wait(Config.EFFECT_SETTINGS.GLOW_FADE_OUT_DURATION * 0.5) -- 6. Fade Out, Restore Sky print("Step 6: Fade Out & Restore Sky") activeTweens.fade3 = Utils.runFade("Out", Config.EFFECT_SETTINGS.FADE_DURATION) Utils.playSound(Config.SOUND_IDS.COMPLETE, 0.5, rootPart) Effects.setSkybox(false) -- Restore original sky Utils.waitForTween(activeTweens.fade3) -- 7. Restore State (Position, Camera, Player Controls, VISIBILITY) - While screen is black print("Step 7: Restore State (Instant)") rootPart.CFrame = originalState.CFrame -- Reset position instantly humanoid.WalkSpeed = originalState.WalkSpeed humanoid.JumpPower = originalState.JumpPower humanoid:SetStateEnabled(Enum.HumanoidStateType.Jumping, originalState.IsJumpingEnabled) Utils.resetCharacterTransparency(character) -- CRITICAL: Reset transparency here -- Start camera return tween (will run during fade in) activeTweens.cameraReturn = Utils.createTween(Camera, {CFrame = originalState.CameraCFrame}, Config.EFFECT_SETTINGS.CAMERA_RETURN_DURATION, Enum.EasingStyle.Sine, Enum.EasingDirection.InOut) activeTweens.cameraReturn:Play() activeTweens.cameraReturn.Completed:Connect(function() Camera.CameraType = originalState.CameraType Camera.CameraSubject = originalState.CameraSubject print(" -> Camera type/subject restored.") end) -- 8. Final Fade In print("Step 8: Final Fade In") activeTweens.fade4 = Utils.runFade("In", Config.EFFECT_SETTINGS.FADE_DURATION) Utils.waitForTween(activeTweens.fade4) print("Transformation: Sequence Completed Successfully.") end) -- End of pcall if not success then warn("Transformation Error:", err) warn("Attempting emergency cleanup...") end -- Final Cleanup (runs regardless of success/failure) cleanup() end) -- End of task.spawn end return Transformation -- client/ClassTransformationClient.lua -- Main client entry point for class transformation system print("Loading Class Transformation System...") -- Define base path for easier requires local basePath = script.Parent.ClassTransformation -- Require necessary modules local Config = require(basePath.Config) local UI = require(basePath.UI) local Transformation = require(basePath.Transformation) -- State local currentClass = nil --[[ Event Connections ]] -- Handle receiving class data from server Config.Remotes.LoadClass.OnClientEvent:Connect(function(className) print("Client: Received class data:", className) currentClass = className or nil -- Store the current class (or nil if none) end) -- Handle selecting a class via UI local function onSelectClass(className) print("Client: Selecting class:", className) UI.hideAllClassGUIs() -- Hide UI immediately Config.Remotes.SelectClass:FireServer(className) -- Inform server Transformation.play(className) -- Start visual transformation end -- Handle proximity prompt trigger local sukunaNpc = workspace.NPCs:WaitForChild("Sukuna") local proximityPrompt = sukunaNpc and sukunaNpc:FindFirstChild("ProximityPrompt") if proximityPrompt then proximityPrompt.Triggered:Connect(function() print("Client: ProximityPrompt triggered. Current class:", currentClass) if currentClass then -- Player already has a class, show their specific GUI UI.showClassGUI(currentClass) else -- Player needs to select a class UI.showSelectionGUI() end end) else warn("Client: ProximityPrompt not found for Sukuna NPC.") end --[[ Initialization ]] -- Setup UI buttons and connect their click events local abyssButton, voidButton, lightButton, closeButton = UI.initializeClassSelection() abyssButton.MouseButton1Click:Connect(function() onSelectClass("Abyss") end) voidButton.MouseButton1Click:Connect(function() onSelectClass("Void") end) lightButton.MouseButton1Click:Connect(function() onSelectClass("Light") end) closeButton.MouseButton1Click:Connect(function() UI.hideAllClassGUIs() end) -- Just close selection -- Initial setup ClassSelectionGUI.Enabled = false -- Ensure selection is hidden initially UI.hideAllClassGUIs() -- Hide all class-specific GUIs initially -- Request initial class state from server Config.Remotes.LoadClass:FireServer() print("Class Transformation System Loaded (Rework v1)") **Explanation of Changes and Fix Attempts:** 1. **Modular Structure:** Code is split into `Config`, `Utils`, `Effects`, `UI`, and `Transformation` modules for better organization. The main `ClassTransformationClient.lua` script now just wires everything together. 2. **Persistent Fade GUI:** The `Utils.runFade` function uses a single, persistent `ScreenGui` and `Frame` to avoid repeatedly creating/destroying GUI elements, which can sometimes cause issues. 3. **Robust Cleanup:** The `cleanup` function inside `Transformation.lua` explicitly destroys all created effects (aura, glow, trail, attachments, container) and disconnects the camera follow loop. It also attempts to restore player state as a final measure. This cleanup runs whether the transformation succeeds or fails. 4. **Explicit Transparency Reset:** `Utils.resetCharacterTransparency` iterates through all descendants, attempting to set both `Transparency` and `LocalTransparencyModifier` to 0 for `BasePart` and `Decal` instances. This is called *while the screen is faded to black* just before the final fade-in, which is the most reliable time to do it. 5. **Effect Parenting:** The temporary energy waves are now parented to the `effectsContainer` folder, which itself is parented to `workspace`. This container is destroyed during cleanup, which should help prevent the "gray part" issue if it was caused by lingering wave parts. 6. **Sound Handling:** Hover sounds are no longer auto-destroyed. Other sounds use `task.delay` for safer auto-destruction after they finish playing. 7. **Async Flow:** The main transformation sequence uses `task.spawn` to run without blocking the main thread and `Utils.waitForTween` (which uses `Tween.Completed:Wait()`) to manage the sequential steps. 8. **Debounce:** Added an `isTransforming` flag to prevent starting a new transformation while one is already in progress. 9. **Error Handling:** The main sequence is wrapped in a `pcall` to catch errors. The `cleanup` function runs regardless, attempting to restore a sane state. 10. **Configuration:** All magic numbers, IDs, and settings are centralized in `Config.lua`. **To Use:** 1. Place the `ClassTransformation` folder (containing the 5 Lua modules) inside your `client` script location (e.g., `StarterPlayerScripts`). 2. Place the `ClassTransformationClient.lua` script directly inside `StarterPlayerScripts` (or wherever your main client scripts run). 3. **Crucially, update the placeholder Sound IDs** in `client/ClassTransformation/Config.lua` with your actual `rbxassetid://` values. 4. Ensure the GUI names (`AbyssGUI`, `LightGUI`, `VoidGUI`, `ClassSelectionGUI`) and the RemoteEvent names (`SelectClassEvent`, `LoadClassEvent`) match what you have in your game explorer. 5. Ensure the NPC path (`workspace.NPCs:WaitForChild("Sukuna")`) is correct. This rework is significantly different. Test it thoroughly to see if the invisibility and gray part issues are resolved and if the overall effect feels smoother.